Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DATAUP-246, css to scss: remove unneeded dir #1901

Merged
merged 2 commits into from
Oct 29, 2020
Merged

DATAUP-246, css to scss: remove unneeded dir #1901

merged 2 commits into from
Oct 29, 2020

Conversation

ialarmedalien
Copy link
Collaborator

Description of PR purpose/changes

Removing html_mockups folder, which has not been edited in five years.

Jira Ticket / Issue

https://kbase-jira.atlassian.net/browse/DATAUP-246

@ialarmedalien ialarmedalien self-assigned this Oct 27, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 17.007% when pulling 3beb652 on DATAUP-246-css_to_scss-remove_unneeded_dir into a30f5aa on truss.

briehl
briehl approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@briehl briehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm for removing these from the repo, but can we keep / stash the kbase_styles.html file in Google Docs or somewhere? That's currently how things are styled, and it would be nice to have to point to.

@ialarmedalien
Copy link
Collaborator Author

I've moved the style guide into the kbase-extension/static/kbase/template/, so you can view it if you manually enter the template address into your browser (i.e. http://localhost:8888/narrative/static/kbase/templates/kbase_styles.html). I've also updated it to use the current stylesheet.

@sonarcloud
Copy link

sonarcloud bot commented Oct 29, 2020

SonarCloud Quality Gate failed.

Bug B 4 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ialarmedalien ialarmedalien merged commit fd0a226 into truss Oct 29, 2020
@ialarmedalien ialarmedalien deleted the DATAUP-246-css_to_scss-remove_unneeded_dir branch October 29, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briehl briehl briehl approved these changes

Assignees

@ialarmedalien ialarmedalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ialarmedalien @coveralls @briehl