refactor: add flags correctly

kbrsh · Dec 17, 2017 · 597756c · 597756c
1 parent 5dccf1d
commit 597756c
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 3 deletions.
diff --git a/dist/moon.js b/dist/moon.js
@@ -671,6 +671,7 @@
 
     // Data Flags
     var FLAG_SVG = 1;
+    var FLAG_STATIC = 1 << 1;
 
     // Trim Whitespace
     var trimWhitespace = function(value) {
@@ -970,6 +971,15 @@
       return root.children[0];
     }
 
+    var generateNodeFlag = function(data, flag) {
+      var flags = data.flags;
+      if(flags === undefined) {
+        data.flags = flag;
+      } else {
+        data.flags = flags | flag;
+      }
+    }
+
     var generateStaticNode = function(nodeOutput, staticNodes) {
       var staticNodesLength = staticNodes.length;
       staticNodes[staticNodesLength] = nodeOutput;
@@ -999,7 +1009,7 @@
 
         // Mark SVG elements
         if(SVG_ELEMENTS.indexOf(type) !== -1) {
-          data.flags = data.flags | FLAG_SVG;
+          generateNodeFlag(data, FLAG_SVG);
         }
 
         // Generate props

diff --git a/dist/moon.min.js b/dist/moon.min.js
diff --git a/src/compiler/constants.js b/src/compiler/constants.js
@@ -41,6 +41,7 @@ const SVG_ELEMENTS = ["animate", "circle", "clippath", "cursor", "defs", "desc",
 
 // Data Flags
 const FLAG_SVG = 1;
+const FLAG_STATIC = 1 << 1;
 
 // Trim Whitespace
 const trimWhitespace = function(value) {

diff --git a/src/compiler/generator.js b/src/compiler/generator.js
@@ -1,3 +1,12 @@
+const generateNodeFlag = function(data, flag) {
+  const flags = data.flags;
+  if(flags === undefined) {
+    data.flags = flag;
+  } else {
+    data.flags = flags | flag;
+  }
+}
+
 const generateStaticNode = function(nodeOutput, staticNodes) {
   const staticNodesLength = staticNodes.length;
   staticNodes[staticNodesLength] = nodeOutput;
@@ -27,7 +36,7 @@ const generateNode = function(node, parentNode, state) {
 
     // Mark SVG elements
     if(SVG_ELEMENTS.indexOf(type) !== -1) {
-      data.flags = data.flags | FLAG_SVG;
+      generateNodeFlag(data, FLAG_SVG);
     }
 
     // Generate props