accurate error messages and tests

kbrsh · Apr 5, 2019 · c4827e7 · c4827e7
1 parent e3b9b04
commit c4827e7
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/packages/moon/dist/moon.js b/packages/moon/dist/moon.js
@@ -191,7 +191,7 @@
 				var typeExec = typeRE.exec(input);
 
 				if ("development" === "development" && typeExec === null) {
-					lexError("Lexer expected a valid opening or closing tag.", input, i);
+					lexError("Lexer expected a valid opening or self-closing tag.", input, i);
 				}
 
 				var typeMatch = typeExec[0];

diff --git a/packages/moon/src/compiler/lexer/lexer.js b/packages/moon/src/compiler/lexer/lexer.js
@@ -155,7 +155,7 @@ export function lex(input) {
 			const typeExec = typeRE.exec(input);
 
 			if (process.env.MOON_ENV === "development" && typeExec === null) {
-				lexError("Lexer expected a valid opening or closing tag.", input, i);
+				lexError("Lexer expected a valid opening or self-closing tag.", input, i);
 			}
 
 			const typeMatch = typeExec[0];

diff --git a/packages/moon/test/compiler/lexer.test.js b/packages/moon/test/compiler/lexer.test.js
@@ -96,21 +96,21 @@ test("lex error from unclosed opening bracket", () => {
 test("lex error from invalid opening tag", () => {
 	console.error = jest.fn();
 
-	expect(Array.isArray(lex("<div"))).toBe(true);
+	expect(() => {lex("<div");}).toThrow();
 	expect(console.error).toBeCalled();
 });
 
-test("lex error from invalid closing tag", () => {
+test("lex error from invalid self-closing tag", () => {
 	console.error = jest.fn();
 
-	expect(Array.isArray(lex("<div/"))).toBe(true);
+	expect(() => {lex("<input/");}).toThrow();
 	expect(console.error).toBeCalled();
 });
 
-test("lex error from unclosed self-closing tag", () => {
+test("lex error from unclosed closing tag", () => {
 	console.error = jest.fn();
 
-	expect(Array.isArray(lex("</input"))).toBe(true);
+	expect(Array.isArray(lex("</div"))).toBe(true);
 	expect(console.error).toBeCalled();
 });