-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1.0.0 beta #44
V1.0.0 beta #44
Conversation
Thanks for the PR! Love the idea of a nav. I made a couple of changes, making things more appealing, and using system fonts instead of Open Sans. Some files I think that added some extra bloated features were also removed. Adding a navigation component would be cool, but I think there should be one base class for a navigation, and alignment shouldn't be built in. Why? Wing is meant to be as minimal as possible, using a minimal amount of classes, making it intuitive for developers. Some improvements:
Also, if you could |
Yeah, I went back and forward between the nav options. I'll take care of these and send another PR. |
# Conflicts: # dist/wing.css # dist/wing.min.css # gulpfile.js
@@ -35,10 +35,26 @@ | |||
justify-content: center; | |||
} | |||
|
|||
.right { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use something like .nav.right
instead of .right
, as it might interfere with other classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.right
could have multiple uses though. it's the equivalent to .center
@kingpixil updated nav utility classes |
Sorry, I see what you mean. Do you think these should be added as utilities, or specifically for the navigation? |
I can go either way. Personally, nav specific classes for |
Cool, I'd say let's kill two birds with one stone, add |
Done. Reverted the utility classes back to their original generic I'm going to hop on your gitter chat - I've got a few questions whenever you get a minute. |
Looking good! I'll be on Gitter for any questions, thanks for the PR! 🙌 |
Navigation
Added basic navigation with several configuration options (#28).
Options
Navigation Default
Navigation Center
Navigation Right
Editor Config
Added .editorconfig to keep coding style consistent.