Add autoloader to allow manual installation and update documentation #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion. The custom autoloader created by this commit translates class names into filesystem locations by a simple rule: it replaces backslashes with frontslashes, and adds ".php" on the end. Two locations are searched for this class implementation file: first we check under lib/, then under test/. The existing test/bootstrap.php checked for vendor/autoload.php and would show an error to the user if it did not exist. Now that we have our own autoloader, we can just use that instead. So, test/bootstrap.php was removed, and phpunit.xml.dist was pointed at the new lib/autoload.php for its bootstrap code. Thanks to Artur Weigandt for the implementation of the autoloader.
|
Awesome! Really appreciate those commits clearly separated, it made the reviewing process dead easy! |
|
Nice 👍 |
* Use four spaces for indentation of "if" statements.
* Add a space between parenthesis and braces, e.g. if (foo) {...
* Remove spaces around the string concatenation operator (dot). This
is consistent with its usage in Redmine/Client.php.
|
Ok, I added two more commits to address your comments. The code style fixer thing suggested that I remove whitespace around the dot operator and you've done that in Client.php, so I did that too. |
kbsali
added a commit
that referenced
this pull request
Dec 26, 2014
Add autoloader to allow manual installation and update documentation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix we discussed in #93. Each of the commits should be self-contained and have a descriptive commit message, so I would look at the individual commits to make review easier. If you have any questions let me know!