Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation bar uses title of the pages to compose the breadcrumb #16

Closed
wants to merge 2 commits into from

Conversation

fabrizio2210
Copy link

In some cases the path cannot contain some characters due to the filesystem restriction (e.g /) or it is better not to use it (e.g. ).
Moreover, using the title of the pages allows to be more consistent with the title of the albums.

@kc0bfv
Copy link
Owner

kc0bfv commented Apr 4, 2021

Thanks - I added the first commit, the second didn't seem like the same issue, and it was really messing up the way things looked when clicking on a photo.

I modified the way this was done to make this an option in the config file. By default - old method is used. The breadcrumb is intended to look like a path, thus the URL part. However - it makes sense that the title would go there too - so, it's an option.

Thanks for the submission!

@kc0bfv kc0bfv closed this Apr 4, 2021
@fabrizio2210
Copy link
Author

fabrizio2210 commented Apr 5, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants