Google Play Books + Zip Archive Fix #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Harold. That looks good; I appreciate the input and have merged the pull request, bumped the version number and re-published to npm. Thanks! |
|
Awesome! Happy to contribute :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @kcartlidge !
nodepubhad been creating ebooks for me that worked in iBooks and Calibre but no in Google Play Books. There's an upload feature, and attempting to upload a book would yield an error.I had also noticed that the zip seemed to have a weird structure when I inspected it in my IDE.
Looking through the code, I found null folders were being appended to the archive. I removed that line and it fixed the structure issue.
However, I still wasn't able to add books to Google Play. I inspected the created book with Calibre and searched for bugs. Calibre suggested
<base href='.' />was pointing to something that did not exist.So I removed that. And now created books can be uploaded to Google Books! 😄
Let me know if these changes look good or if there's any concerns 👍 .