Support ruby-1.8.x (String#force_encoding doesn't exist on 1.8.x) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. I'm kind of in the middle of a Big Rewrite™ and one of my goals was not caring about 1.8 compatibility. (It's small enough a library that I could keep a 1.8 branch, though. Maybe.) |
|
I think I would prefer this patch to define String#force_encoding to just return self on 1.8 instead of syntactically pissing over every bit of code that calls it, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
Basepath is just what I've wanted ever!
So I wanna use it on ruby-1.8.7 . And I changed some code to support 1.8.x .
I wish you to merge this patch and push to rubygems.org .