Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/dict #77

Merged
merged 11 commits into from
Apr 27, 2022
Merged

Feature/dict #77

merged 11 commits into from
Apr 27, 2022

Conversation

kcjpop
Copy link
Owner

@kcjpop kcjpop commented Apr 27, 2022

What

Add a page /dict/en-vi to show all words of a dict. Prolly good for discoverability and SEO 🤷

image

@kcjpop
Add endpoint to get all words of a dict
c620c8d 
Signed-off-by: An Cao <kcj.pop.com@gmail.com>
@kcjpop
Show words in /dict/en-vi
8247849 
Signed-off-by: An Cao <kcj.pop.com@gmail.com>
@kcjpop
Show word count and select word per page
fd2e3f5 
Signed-off-by: An Cao <kcj.pop.com@gmail.com>
@kcjpop
Add option to not merge router query
26f16ea 
Signed-off-by: An Cao <kcj.pop.com@gmail.com>
@kcjpop
Show truncated pagination
aec88f5 
Signed-off-by: An Cao <kcj.pop.com@gmail.com>
@kcjpop
Show links to dict in homepage
55077ad 
Signed-off-by: An Cao <kcj.pop.com@gmail.com>
@kcjpop
Fix opengraph
10180e7 
Signed-off-by: An Cao <kcj.pop.com@gmail.com>
@kcjpop
Format numbers
f80f567 
Signed-off-by: An Cao <kcj.pop.com@gmail.com>
@kcjpop
Test TruncatedPagination
ecc350e 
Signed-off-by: An Cao <kcj.pop.com@gmail.com>
@kcjpop
Tests for /dict/:name
2ac92aa 
Signed-off-by: An Cao <kcj.pop.com@gmail.com>
@kcjpop
Fix pagination on mobile
729d58b 
Signed-off-by: An Cao <kcj.pop.com@gmail.com>
@vercel
Copy link

vercel bot commented Apr 27, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kcjpop/vd/H7ZNaPkzkCgFxraRBPMC4g3baUgb
✅ Preview: https://vd-git-feature-dict-kcjpop.vercel.app

@kcjpop kcjpop requested a review from DangMin April 27, 2022 10:36
@kcjpop kcjpop merged commit 6201f1a into main Apr 27, 2022
@kcjpop kcjpop deleted the feature/dict branch April 27, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DangMin DangMin DangMin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kcjpop @DangMin