Skip to content

Conversation

xxmao123
Copy link
Contributor

@xxmao123 xxmao123 commented Aug 2, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #1

2. What is the scope of this PR (e.g. component or file name):

init.lua
lua/lsp/init.lua
lua/lsp/handlers.lua
syntax/kcl.vim
ftplugin/kcl.lua

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

Add some basic functions and language server.

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa
Copy link
Contributor

He1pa commented Aug 3, 2023

Is this support for vim or neovim?

@xxmao123
Copy link
Contributor Author

xxmao123 commented Aug 3, 2023

Is this support for vim or neovim?

Yes, it supports for neovim.

@xxmao123 xxmao123 requested a review from Peefy August 11, 2023 16:55
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit ca22a86 into kcl-lang:main Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initialize the Vim kcl plugin and add some basic functions.
4 participants