Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gt etc comparisons #15

Merged
merged 1 commit into from
Nov 22, 2023
Merged

add gt etc comparisons #15

merged 1 commit into from
Nov 22, 2023

Conversation

marek-slipski
Copy link
Contributor

Quick Summary

  • Feature addition
  • Bug fix
  • Documentation fix
  • Refactoring current code
  • Other

Related issues

Extended summary

Only "==" comparison was implemented before, this allows for >/</>=/<=.

Pull Request Checklist

  • Code Follows PEP8 guidelines (explain any exceptions)
  • Code is appropriately type hinted
  • Code has associated unit tests where appropriate

@kconnour
Copy link
Owner

Everything looks fine here. I haven't implemented these because I haven't had a use case for them, but since it appears that you do I'm happy to add them.

@kconnour kconnour merged commit eab1523 into kconnour:main Nov 22, 2023
8 checks passed
@marek-slipski marek-slipski deleted the add-gt-lt branch December 1, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants