Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring and cleanup #3

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Refactoring and cleanup #3

wants to merge 16 commits into from

Commits on Feb 24, 2017

  1. Put every import on its own line, ordered alphabetically 

    Fixes PEP 8 error E401 ("multiple imports on one line").
    @homeworkprod
    homeworkprod committed Feb 24, 2017
    Configuration menu
    Copy the full SHA
    543d8c6 View commit details
    Browse the repository at this point in the history

  2. Use not in for non-membership test 

    Fixes PEP 8 error E713 ("test for membership should be 'not in'").
    @homeworkprod
    homeworkprod committed Feb 24, 2017
    Configuration menu
    Copy the full SHA
    2b0a913 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary parentheses

    @homeworkprod
    homeworkprod committed Feb 24, 2017
    Configuration menu
    Copy the full SHA
    716f46a View commit details
    Browse the repository at this point in the history

  4. Put each statement on its own line, adjust whitespace, add blank lines 

    Fixes PEP 8 errors E201, E202, E211 (all about whitespace), and E701
("multiple statements on one line (colon)").
    @homeworkprod
    homeworkprod committed Feb 24, 2017
    Configuration menu
    Copy the full SHA
    2a569e7 View commit details
    Browse the repository at this point in the history

  5. Extract method that checks against Python version 3.x

    @homeworkprod
    homeworkprod committed Feb 24, 2017
    Configuration menu
    Copy the full SHA
    5a94bec View commit details
    Browse the repository at this point in the history

  6. Introduce separate name for joined parts

    @homeworkprod
    homeworkprod committed Feb 24, 2017
    Configuration menu
    Copy the full SHA
    f8773a3 View commit details
    Browse the repository at this point in the history

  7. Reduce code duplication and avoid explicit else branch

    @homeworkprod
    homeworkprod committed Feb 24, 2017
    Configuration menu
    Copy the full SHA
    45bce10 View commit details
    Browse the repository at this point in the history

  8. Extract function to encode string on Python 3.x and above

    @homeworkprod
    homeworkprod committed Feb 24, 2017
    Configuration menu
    Copy the full SHA
    a2e65a0 View commit details
    Browse the repository at this point in the history

  9. Extract functions related to command line argument parsing 

    Put every keyword argument to the parser on a separate line to ease
visual scanning.
    @homeworkprod
    homeworkprod committed Feb 24, 2017
    Configuration menu
    Copy the full SHA
    eb9d89b View commit details
    Browse the repository at this point in the history

  10. Extract version number into "constant"

    @homeworkprod
    homeworkprod committed Feb 24, 2017
    Configuration menu
    Copy the full SHA
    592c125 View commit details
    Browse the repository at this point in the history

  11. Replace star import with actually required function names

    @homeworkprod
    homeworkprod committed Feb 24, 2017
    Configuration menu
    Copy the full SHA
    cfb5952 View commit details
    Browse the repository at this point in the history

  12. Check non-emptiness of suffixes collection regardless of its type 

    This allows the suffixes to be specified as a set instead of a list,
which would be a better semantic fit in this case.
    @homeworkprod
    homeworkprod committed Feb 24, 2017
    Configuration menu
    Copy the full SHA
    fc44130 View commit details
    Browse the repository at this point in the history

  13. Simplify suffix checks by using any

    @homeworkprod
    homeworkprod committed Feb 24, 2017
    Configuration menu
    Copy the full SHA
    b508864 View commit details
    Browse the repository at this point in the history

  14. Extract variable for file count

    @homeworkprod
    homeworkprod committed Feb 24, 2017
    Configuration menu
    Copy the full SHA
    abf680f View commit details
    Browse the repository at this point in the history

  15. Yield found (file, permissions) pairs instead of creating lists 

    This could save a bit of memory, too.

Count files manually as the return value of the function has become a
generator.
    @homeworkprod
    homeworkprod committed Feb 24, 2017
    Configuration menu
    Copy the full SHA
    d84a2b4 View commit details
    Browse the repository at this point in the history

  16. Fine-tune messages

    @homeworkprod
    homeworkprod committed Feb 24, 2017
    Configuration menu
    Copy the full SHA
    bdfdeae View commit details
    Browse the repository at this point in the history