Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth token support + kind cluster helper #27

Merged
merged 6 commits into from
Jun 22, 2023
Merged

Auth token support + kind cluster helper #27

merged 6 commits into from
Jun 22, 2023

Conversation

mjudeikis
Copy link
Contributor

In this PR:

  1. Rename readme.md to README.md (sorry, nitpicking)
  2. Add the ability to deploy with a token file
  3. Remove lets encrypt production issuer as default (does not work well with kind)
  4. Add helper script to deploy end-to-end kind cluster with self-signed certificates and localhost ingress (nginx)

@mjudeikis mjudeikis marked this pull request as ready for review February 14, 2023 14:56
@mjudeikis
Copy link
Contributor Author

happy to "downsize" this PR if people think this is too much :)

hardys
hardys reviewed Feb 14, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
hardys
hardys reviewed Feb 14, 2023
View reviewed changes
README.md Show resolved Hide resolved
hardys
hardys reviewed Feb 14, 2023
View reviewed changes
hack/kind-setup.sh Outdated Show resolved Hide resolved
hardys
hardys reviewed Feb 14, 2023
View reviewed changes
hack/kcp/values.yaml Outdated Show resolved Hide resolved
@hardys
Copy link

hardys commented Feb 14, 2023 •
edited
Loading

happy to "downsize" this PR if people think this is too much :)

Personally I think it's OK as one PR, but it would be nice to break it into a few commits if possible since it's not all strictly related to the kind helper script.

@mjudeikis mjudeikis changed the title Helper scripts for KIND Auth token support + kind cluster helper Feb 15, 2023
@mjudeikis
Copy link
Contributor Author

@hardys is there anything else you want me to change on this?

mamachanko
mamachanko reviewed Feb 22, 2023
View reviewed changes
README.md Show resolved Hide resolved
@hardys hardys mentioned this pull request Mar 15, 2023
Closed
@mjudeikis
Copy link
Contributor Author

@hardys whats missing to merge this?

@xrstf
Copy link
Contributor

xrstf commented Jun 5, 2023

Closing to re-open again, just to get Prow working. Please do not be alarmed.

@xrstf xrstf closed this Jun 5, 2023
@xrstf xrstf reopened this Jun 5, 2023
@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 5, 2023
@kcp-ci-bot kcp-ci-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 12, 2023
xrstf
xrstf reviewed Jun 12, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
xrstf
xrstf reviewed Jun 12, 2023
View reviewed changes
hack/generate-admin-kubeconfig.sh
#!/bin/bash
set -e

hostname=$(cat ./hack/kind-values.yaml | grep externalHostname | cut -d" " -f2- | tr -d '"')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't we use yq (https://github.com/mikefarah/yq) for this, rather than grepping through YAML?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind changing it. My general "rule of thumb" is if tools needs to be installed and is not part of most linux OS - its should not be in the readme, if explicitly not specified that its pre-requisite. Makes it cleaner

@mjudeikis
better way to check for pod existence
fe64db1 
Signed-off-by: Mangirdas <mangirdas@cast.ai>
@mjudeikis mjudeikis added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2023
@mjudeikis
Copy link
Contributor Author

/approved
/lgtm

@kcp-ci-bot
Copy link
Contributor

@mjudeikis: you cannot LGTM your own PR.

In response to this:

/approved
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjudeikis mjudeikis added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2023
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot merged commit a24fea1 into kcp-dev:main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardys hardys hardys left review comments

@mamachanko mamachanko mamachanko left review comments

@xrstf xrstf xrstf left review comments

@ncdc ncdc ncdc left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mjudeikis @hardys @xrstf @kcp-ci-bot @ncdc @mamachanko