Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change issuers & alliasing #38

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Change issuers & alliasing #38

merged 1 commit into from
Jul 10, 2023

Conversation

mjudeikis
Copy link
Contributor

  1. Adds better control for issuers (Self signed, Lets encrypt)
  2. Add SA flags to KCP
  3. Adds host aliasing to pod so we can deploy in 'poor-man-deployment' mode where is no DNS for KCP and its internal to kube. Same applies if you deploy dex without proper dns.
  4. Add internal service account to KCP
  5. Add permissions change init container for KCP (Thanks to Digital ocean k8s it does not work without it in there..)

@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 22, 2023
embik
embik requested changes Jun 23, 2023
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits I have.

charts/kcp/templates/kcp.yaml Outdated Show resolved Hide resolved
charts/kcp/templates/certmanagerissuer.yaml Show resolved Hide resolved
charts/kcp/templates/certmanagerissuer.yaml Show resolved Hide resolved
embik
embik requested changes Jul 5, 2023
View reviewed changes
charts/kcp/templates/kcp.yaml Outdated Show resolved Hide resolved
@mjudeikis
Copy link
Contributor Author

quick render test:

helm template kcp . --set letsEncrypt.enabled=true --set letsEncrypt.production.enabled=true --set letsEncrypt.production.email=foo@foo.foo

embik
embik approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

🎉

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2023
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b2b1905b98bb3172d75357d2e07350168a6f011d

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2023
@kcp-ci-bot kcp-ci-bot merged commit 22d8780 into kcp-dev:main Jul 10, 2023
@embik embik mentioned this pull request Jul 10, 2023
Merged
@xrstf xrstf mentioned this pull request Sep 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

Assignees

@embik embik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjudeikis @kcp-ci-bot @embik