Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 add github actions to push docs #2153

Merged

Conversation

avinal
Copy link
Member

@avinal avinal commented Oct 7, 2022

Summary

This GitHub Actions does the following:

  • generates CLI docs
  • generates CRD refs
  • saves new tags as archive in gh-pages branch for doc versioning
  • builds and deploys hugo docs to github pages

Needs

@avinal avinal changed the title add github actions to push docs to kcp-dev.github.io 📖 add github actions to push docs to kcp-dev.github.io Oct 7, 2022
@avinal avinal marked this pull request as draft October 18, 2022 18:40
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2022
@avinal avinal changed the title 📖 add github actions to push docs to kcp-dev.github.io 📖 add github actions to push docs Oct 18, 2022
@avinal avinal marked this pull request as ready for review October 19, 2022 04:24
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2022
@openshift-ci openshift-ci bot requested a review from csams October 19, 2022 04:24
@avinal
Copy link
Member Author

avinal commented Oct 19, 2022

Need to fix hack/verify-go-versions.sh, it is grepping go-version from hugo-version 😆

@avinal
Copy link
Member Author

avinal commented Oct 19, 2022

Need to fix hack/verify-go-versions.sh, it is grepping go-version from hugo-version laughing

fixed ✅

This GitHub Actions does the following:
- generates CLI docs
- generates CRD refs
- saves new tags as archive in gh-pages branch for doc versioning
- builds and deploys hugo docs to github pages
- fix go version check mistaking hugo-version as go-version

Signed-off-by: Avinal Kumar <avinal@redhat.com>
@sttts
Copy link
Member

sttts commented Oct 19, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2022
@openshift-merge-robot openshift-merge-robot merged commit cba3628 into kcp-dev:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants