✨ Update DNS resources when syncer starts #2420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
lionelvillard
force-pushed
the
update-dns
branch
from
fd06e1b
to
7d06422
Compare
lionelvillard
force-pushed
the
update-dns
branch
from
7d06422
to
051529e
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
lionelvillard
force-pushed
the
update-dns
branch
6 times, most recently
from
12d1fa0
to
dfa905f
Compare
lionelvillard
changed the title
davidfestal
reviewed
Nov 29, 2022
lionelvillard
force-pushed
the
update-dns
branch
from
dfa905f
to
56a8726
Compare
davidfestal
reviewed
Dec 2, 2022
davidfestal
added
the
area/transparent-multi-cluster
|
/test e2e-shared known flake: #2278 |
|
@davidfestal do you anticipate this to be reviewed and in a mergeable state this week? If not, could we please move it to v0.11? |
|
I anticipate to have it reviewed and merged. |
lionelvillard
force-pushed
the
update-dns
branch
from
b5e46be
to
b165009
Compare
davidfestal
reviewed
Dec 6, 2022
lionelvillard
force-pushed
the
update-dns
branch
from
b165009
to
ce2a03f
Compare
|
/test e2e-shared |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidfestal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Minimalist (ie not over-engineered) update support for DNS resources. Only check if the DNS deployment image is up-to-date. The update logic can be later modified to cover more type of updates.
Related issue(s)
Fixes #2357