Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Install Calico in kind for CI testing #2431

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

lionelvillard
Copy link
Contributor

Summary

Default kind configuration does not support network policies. This PR modifies the kind configuration disabling kindnet and install Calico.

Related issue(s)

/cc @davidfestal

@davidfestal
Copy link
Member

Do you think you could upgrade the kind version to 0.17.0 at the same time ?
It is done in another PR, but it seems to me that this kind version upgrade fits better in this PR.

Copy link
Member

@davidfestal davidfestal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented about adding an upgrade of the kind version in this PR.

@davidfestal davidfestal added the area/transparent-multi-cluster Related to scheduling of workloads into pclusters. label Dec 2, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 17, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 4, 2023
@davidfestal
Copy link
Member

/test e2e-sharded

@lionelvillard
Copy link
Contributor Author

/test-required

@lionelvillard
Copy link
Contributor Author

TestDeploymentCoordinator "flake"

/test-required

@davidfestal
Copy link
Member

TestDeploymentCoordinator "flake"

/test-required

TBF it seems more than a flake here, since it never succeeds. Wondering if something in the change breaks them.

@davidfestal
Copy link
Member

@stevekuznetsov So do you confirm it is OK for you if we still merge this PR and @lionelvillard would create a follow-up PR for the changes you requested in this slack thread: https://kubernetes.slack.com/archives/C021U8WSAFK/p1672913451512589 ?

@davidfestal
Copy link
Member

@stevekuznetsov So do you confirm it is OK for you if we still merge this PR and @lionelvillard would create a follow-up PR for the changes you requested in this slack thread: https://kubernetes.slack.com/archives/C021U8WSAFK/p1672913451512589 ?

I assume yes, as you mentioned here https://kubernetes.slack.com/archives/C021U8WSAFK/p1672931932256269?thread_ts=1672913451.512589&cid=C021U8WSAFK

Let me approve then.

@davidfestal
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidfestal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2023
@davidfestal
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2023
@openshift-merge-robot openshift-merge-robot merged commit 32503be into kcp-dev:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/transparent-multi-cluster Related to scheduling of workloads into pclusters. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants