Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 Debug deployment coordinator e2e #2555

Conversation

davidfestal
Copy link
Member

Summary

Add a check in the Deployment Coordinator e2e test, that will try to list deployment, to validate they are correctly exposed by the root compute APIExport URL, before starting the deployment coordinator.

Related issue(s)

This should help debugging the flake recorded in issue #2501

Signed-off-by: David Festal <dfestal@redhat.com>
@davidfestal
Copy link
Member Author

This check is useful because of the following messages found several times in failing test runs:

deployment-coordinator: W0105 15:26:29.720029   13015 reflector.go:324] k8s.io/client-go@v0.0.0-20221221132345-4bcc0e78af51/tools/cache/reflector.go:167: failed to list *v1.Deployment: the server could not find the requested resource (get deployments.apps)
deployment-coordinator: E0105 15:26:29.720089   13015 reflector.go:138] k8s.io/client-go@v0.0.0-20221221132345-4bcc0e78af51/tools/cache/reflector.go:167: Failed to watch *v1.Deployment: failed to list *v1.Deployment: the server could not find the requested resource (get deployments.apps)
deployment-coordinator: W0105 15:26:30.733178   13015 reflector.go:324] k8s.io/client-go@v0.0.0-20221221132345-4bcc0e78af51/tools/cache/reflector.go:167: failed to list *v1.Deployment: the server could not find the requested resource (get deployments.apps)

Copy link
Contributor

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2023
@openshift-merge-robot openshift-merge-robot merged commit 0f49416 into kcp-dev:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants