Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 Update logcheck to 0.4.0 #2587

Merged
merged 1 commit into from
Jan 10, 2023
Merged

馃尡 Update logcheck to 0.4.0 #2587

merged 1 commit into from
Jan 10, 2023

Conversation

vincepri
Copy link
Contributor

Signed-off-by: Vince Prignano vincepri@redhat.com

Summary

This patch also disables the check for logger keys against upstream naming conventions

Related issue(s)

Fixes #2538

@openshift-ci openshift-ci bot requested review from csams and ncdc January 10, 2023 16:33
@stevekuznetsov
Copy link
Contributor

/hold
Would appreciate landing this after #2576

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2023
@stevekuznetsov
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2023
Signed-off-by: Vince Prignano <vincepri@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2023
@vincepri
Copy link
Contributor Author

/retest

@stevekuznetsov
Copy link
Contributor

/hold cancel
/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 10, 2023
@openshift-merge-robot openshift-merge-robot merged commit 8d3a51e into kcp-dev:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Makefile calls for outdated release of logcheck
3 participants