-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 e2e: TestAuditLogs remove duplicate audit-log-path #2610
🌱 e2e: TestAuditLogs remove duplicate audit-log-path #2610
Conversation
/cc @ncdc @stevekuznetsov ref this discussion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment applies elsewhere - I'm not clear on what the benefit is of pulling the dirs up if they are not used at the higher scope?
If we define the artifactDir in the test we can read the audit log from that directory instead of passing a duplicate option with a different path
0d73172
to
cab2d59
Compare
/retitle 🌱 e2e: TestAuditLogs remove duplicate audit-log-path |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
||
t.Cleanup(func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming we lost this since we defer cleanup to the scratch-dir cleanup routines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes since the audit-log ends up in the regular artifactDir which is created via testing.TempDir it'll be cleaned with the other test output unless ARTIFACT_DIR is specified.
Summary
This decouples scratch directory creation from the
PrivateKcpServer
fixture, so that we can log to the regular artifactDir location (which means the log data will show up in saved CI job artifacts), and avoid the duplicate flag and associated test cleanup.Related issue(s)
Follows on from #2591 to ensure audit log output shows up in the saved CI artifacts for all tests.