-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 e2e/reconciler/workspace: use cluster client #2639
🐛 e2e/reconciler/workspace: use cluster client #2639
Conversation
@@ -177,7 +177,7 @@ func TestWorkspaceController(t *testing.T) { | |||
kcpClient, err := kcpclusterclientset.NewForConfig(cfg) | |||
require.NoError(t, err) | |||
|
|||
expecterClient, err := kcpclusterclientset.NewForConfig(server.RootShardSystemMasterBaseConfig(t)) | |||
expecterClient, err := kcpclusterclientset.NewForConfig(cfg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expectedClient?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, will update, thx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will remove it and simply use kcpClient
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
previously the tests were trying to access a workspace by providing a full path to a root shard client which couldn't have been resolved by the local proxy.
9ef4b80
to
b82703a
Compare
/assign @ncdc |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
previously the tests were trying to access a workspace by providing a full path to a root shard client which couldn't have been resolved by the local proxy.
Related issue(s)
xref: #2596