Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Fix make install doesn't exit without required tools #2760

Conversation

wangke19
Copy link
Contributor

@wangke19 wangke19 commented Feb 8, 2023

Summary

Fixed the actual bug, without requirement tools, the target install doesn't check requirements and target build doesn't exit compiling.

Fixes #2759

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 8, 2023

Hi @wangke19. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wangke19
Copy link
Contributor Author

wangke19 commented Feb 8, 2023

Here are test results for the PR fix:

# make build
bash: jq: command not found
bash: jq: command not found
bash: jq: command not found
jq not found in /root/go/src/kcp/bin:/root/go/src/kcp/hack/tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/root/bin:/usr/local/go/bin:/root/go/bin:/root/bin:/usr/local/go/bin:/root/go/bin
make: *** [Makefile:103: require-jq] Error 1

# make install
bash: jq: command not found
bash: jq: command not found
bash: jq: command not found
jq not found in /root/go/src/kcp/bin:/root/go/src/kcp/hack/tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/root/bin:/usr/local/go/bin:/root/go/bin:/root/bin:/usr/local/go/bin:/root/go/bin
make: *** [Makefile:103: require-jq] Error 1

@ncdc ncdc changed the title 馃悰 Fix make install doesn't exit without requirement tools 馃悰 Fix make install doesn't exit without required tools Feb 8, 2023
@ncdc
Copy link
Member

ncdc commented Feb 8, 2023

Thanks for the PR!

/ok-to-test
/lgtm
/approve

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2023
@openshift-merge-robot openshift-merge-robot merged commit 09cbd2f into kcp-dev:main Feb 8, 2023
@wangke19 wangke19 deleted the fix-without-requirement-not-quit branch February 9, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug:make install does not exit without requirement tools
3 participants