Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃尡 Add cache informers for synctargets/locations in placement controller #2915

Merged
merged 2 commits into from
Mar 30, 2023
Merged

馃尡 Add cache informers for synctargets/locations in placement controller #2915

merged 2 commits into from
Mar 30, 2023

Conversation

nrb
Copy link
Contributor

@nrb nrb commented Mar 23, 2023

Signed-off-by: Nolan Brubaker nolan@nbrubaker.com

Summary

Add cache informer for locations in placement controller.

Related issue(s)

Part of #2900

@nrb nrb requested a review from davidfestal March 23, 2023 20:26
stevekuznetsov
stevekuznetsov reviewed Mar 23, 2023
View reviewed changes
Copy link
Contributor

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are locations already selected for replication? How? Will edge-mc need to mark theirs, too?

pkg/reconciler/workload/placement/placement_controller.go Outdated Show resolved Hide resolved
@nrb
Copy link
Contributor Author

nrb commented Mar 27, 2023

Are locations already selected for replication? How? Will edge-mc need to mark theirs, too?

Yes, they're already selected. Right now we have a hard coded list. There's not currently a way for external resources to be added.

This came up in a community meeting recently too. I've made #2923 to track that request.

@stevekuznetsov
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 27, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2023
@ncdc
Copy link
Member

ncdc commented Mar 27, 2023

@nrb could you please also update the PR title - I think some words are accidentally missing?

davidfestal
davidfestal approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@davidfestal davidfestal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when changes requested by Andy are implemented, and conflicts are fixed

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2023
@nrb
Add cache informers for placement and synctargets
3a2c654 
Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
@nrb nrb changed the title 馃尡 Add cache informer to for location 馃尡 Add cache informers for syntargets/locations in placement controller Mar 29, 2023
@nrb
Fix names
d52a3df 
Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2023
@nrb
Copy link
Contributor Author

nrb commented Mar 29, 2023

@davidfestal & @ncdc changes made and PR rebased

@nrb nrb changed the title 馃尡 Add cache informers for syntargets/locations in placement controller 馃尡 Add cache informers for synctargets/locations in placement controller Mar 29, 2023
@stevekuznetsov
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidfestal, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [davidfestal,stevekuznetsov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 0ba47ec into kcp-dev:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts sttts left review comments

@stevekuznetsov stevekuznetsov stevekuznetsov left review comments

@ncdc ncdc ncdc requested changes

@davidfestal davidfestal davidfestal approved these changes

Assignees

@ncdc ncdc

@davidfestal davidfestal

@stevekuznetsov stevekuznetsov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nrb @stevekuznetsov @ncdc @davidfestal @sttts @openshift-merge-robot