✨ Add CRDs to built-in types #3018
Conversation
Signed-off-by: Mangirdas Judeikis <mangirdas@judeikis.lt>
kcp-ci-bot
added
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
kcp-ci-bot
added
the
size/S
|
/test all |
|
/test pull-kcp-lint |
kcp-ci-bot
removed
the
do-not-merge/work-in-progress
|
/test pull-kcp-lint |
|
/retest |
1 similar comment
|
/retest |
|
|
||
| // CRDs are not included in the genericcontrolplane scheme (because they're part of the apiextensions apiserver), | ||
| // so we have to manually add them | ||
| allKnownTypes[schema.GroupVersionKind{Group: "apiextensions.k8s.io", Version: "v1", Kind: "CustomResourceDefinition"}] = reflect.TypeOf(struct{}{}) |
There was a problem hiding this comment.
I don't think so. We add this to schema bellow? No?
| reference := r.Reference() // recursive CRDs are not supported | ||
| if reference == "io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.JSONSchemaProps" { | ||
| return | ||
| } |
There was a problem hiding this comment.
what's the consequence of this? Who wants to crdpull CRDs?
There was a problem hiding this comment.
need to test crd pulling case :/ tbh this was very quick PR. Needs more testing. And this feedback kelps to identify the areas for testing :)
There was a problem hiding this comment.
Note that pulling the CRD type, not CRDs (= instances), is very meta 😄
There was a problem hiding this comment.
I think this does not impact CRD pulling. We already converts APIS into CRDs
Tested crd-puller and it just worked. Might be some edge cases but not sure how to identify those without knowing what I'm looking for ;)
| @@ -33,6 +34,7 @@ func init() { | |||
| install.Install(Scheme) | |||
| authenticationinstall.Install(Scheme) | |||
| authorizationinstall.Install(Scheme) | |||
| apiextensionsinstall.Install(Scheme) | |||
|
/lgtm |
|
LGTM label has been added. Git tree hash: d63568189c4369e1f79e94b2b6e76a7bcc773658
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Summary
Attempt to add CRDs to built-in types so they could be claimed
Related issue(s)
Fixes #
Release Notes