Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add Tilt setup to contrib #3037

Merged
merged 2 commits into from
Apr 1, 2024
Merged

✨ Add Tilt setup to contrib #3037

merged 2 commits into from
Apr 1, 2024

Conversation

mjudeikis
Copy link
Contributor

@mjudeikis mjudeikis commented Oct 28, 2023 •
edited

Summary

Adds test tilt setup to contrib

Missing parts:

  • Add auto prometheus token reading from metrics battery Not found nice quick. Leaving manual.
  • @embik admin battery needed as it fails now on startup most of the times
  • Fix make file

Related issue(s)

Fixes #

Release Notes

Add contrib folder to run Sharded dev env on Tilt with dex

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Oct 28, 2023
@kcp-ci-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kcp-ci-bot kcp-ci-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 28, 2023
@mjudeikis mjudeikis requested a review from sttts October 28, 2023 10:02
@mjudeikis mjudeikis marked this pull request as ready for review December 15, 2023 19:42
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 15, 2023
@sttts
Copy link
Member

sttts commented Jan 3, 2024

Sgtm

@kcp-ci-bot kcp-ci-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2024
@kcp-ci-bot kcp-ci-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 31, 2024
@mjudeikis mjudeikis mentioned this pull request Mar 31, 2024
Merged
@kcp-ci-bot kcp-ci-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2024
@mjudeikis
Copy link
Contributor Author

kcp-dev/helm-charts#87 needs to merge first

@mjudeikis
Copy link
Contributor Author

/test pull-kcp-test-e2e-shared

mjudeikis
mjudeikis commented Mar 31, 2024
View reviewed changes
contrib/tilt/Tiltfile Outdated Show resolved Hide resolved
@mjudeikis
Tilt sharded dev env
88c36a2 
Signed-off-by: Mangirdas Judeikis <mangirdas@judeikis.lt>
@mjudeikis
Copy link
Contributor Author

/retest

@sttts
Copy link
Member

sttts commented Apr 1, 2024

/lgtm
/approve
/hold

Unhold at will.

@kcp-ci-bot kcp-ci-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2024
@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 86b9ac08d2f1a345a43f180d1afcb4aaec14843d

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2024
@kcp-ci-bot kcp-ci-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2024
@kcp-ci-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@mjudeikis
Copy link
Contributor Author

added nit for "override dex" config as found it one config I needed to be different. I suspect more will come but for now will do.
/unhold
/lgtm

@kcp-ci-bot
Copy link
Contributor

@mjudeikis: you cannot LGTM your own PR.

In response to this:

added nit for "override dex" config as found it one config I needed to be different. I suspect more will come but for now will do.
/unhold
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2024
@mjudeikis mjudeikis added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2024
@kcp-ci-bot kcp-ci-bot merged commit 0d8cc8b into kcp-dev:main Apr 1, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik left review comments

@sttts sttts Awaiting requested review from sttts

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mjudeikis @kcp-ci-bot @sttts @embik