🌱 Remove dependency on cli module and bump dependencies in cli and sdk
#3146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckage Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
kcp-ci-bot
added
release-note-none
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
kcp-ci-bot
added
the
kind/api-change
embik
changed the title
cli module and bump dependencies in cli and sdkcli module and bump dependencies in cli and sdk
kcp-ci-bot
added
the
do-not-merge/work-in-progress
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
embik
changed the title
cli module and bump dependencies in cli and sdkcli module and bump dependencies in cli and sdk
kcp-ci-bot
removed
the
do-not-merge/work-in-progress
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
|
/lgtm |
|
LGTM label has been added. Git tree hash: ee5207b3faf532400592a478441c5f9137ba9248
|
|
/retest looks like a flake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since kcp 0.24.0, the new
clipackage is creating a bit of a problem because its a dependency ofgithub.com/kcp-dev/kcp, but most users would not import it. Thus, the version fromgo.modis used for dependency resolution, which is an invalid one:kcp/go.mod
Line 17 in f4297bd
To avoid having a
replacedirective in every project that importsgithub.com/kcp-dev/kcp, I've moved the small API surface used ingithub.com/kcp-dev/kcp(the main module) togithub.com/kcp-dev/kcp/sdk, a module that both modules depend on anyway.This still means that to build a project from
github.com/kcp-dev/kcp, you must havegithub.com/kcp-dev/kcp/sdkas a dependency as well, but that seems to be the more likely case.In addition, this PR bumps the
cliandsdkmodules to be in sync with the changes done to the main module in #3140.After that, I also ran into the issue that we are using a KCP
apigenfrom v0.21.0 (so quite an old one), so I've changed that logic to use theapigenthat is present in the repository right now. It doesn't make much sense to me to keep using this from previous releases.Related issue(s)
Fixes #
Release Notes