Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for CronJobs #69

Merged
merged 6 commits into from
Jul 6, 2021
Merged

Added support for CronJobs #69

merged 6 commits into from
Jul 6, 2021

Conversation

somayaj
Copy link
Contributor

@somayaj somayaj commented Jun 26, 2021

No description provided.

Copy link
Contributor

@deepu105 deepu105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments, also will wait for the UI part to be added

src/app/cronjobs.rs Show resolved Hide resolved
test_data/cronjobs.yaml Show resolved Hide resolved
@somayaj somayaj requested a review from deepu105 July 4, 2021 19:10
@deepu105
Copy link
Contributor

deepu105 commented Jul 5, 2021

@somayaj I fixed the parsing and tests. Can you add the section to the UI please

@somayaj
Copy link
Contributor Author

somayaj commented Jul 5, 2021 via email

@deepu105
Copy link
Contributor

deepu105 commented Jul 5, 2021

I mean to make cronjobs appear in the UI, you need to add the rendering code under ui/overview.rs. you can follow what is already there for jobs and replicate that

@somayaj
Copy link
Contributor Author

somayaj commented Jul 5, 2021

I mean to make cronjobs appear in the UI, you need to add the rendering code under ui/overview.rs. you can follow what is already there for jobs and replicate that

My bad, I thought I had those in the initial commit. I've checked them in now.

src/ui/overview.rs Show resolved Hide resolved
@deepu105 deepu105 merged commit bbd2aa5 into kdash-rs:main Jul 6, 2021
@deepu105 deepu105 mentioned this pull request Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants