Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn users of the 3.x release of the unsupported status #172

Closed
leggewie opened this issue Jan 23, 2021 · 6 comments
Closed

warn users of the 3.x release of the unsupported status #172

leggewie opened this issue Jan 23, 2021 · 6 comments
Assignees
Labels
📚 documentation Update to non-code (readme, docstrings, typos, …)

Comments

@leggewie
Copy link
Contributor

leggewie commented Jan 23, 2021

I was going to prepare a pull request but apparently github does not allow a pull request to open a new git branch. I suggest to branch a python2 branch off the v3.0.0 tag and point it to the tip of the python2 branch I prepared for the purpose. I then suggest to release a 3.0.1 version to PyPi.

I've taken it as far as I was able to for now, but poetry would not let me compile it. If you don't like the three-second timer, I added it in a separate commit you can easily revert or drop in a rebase.

The motivation for this branch and proposed release comes from the discussion we had in #154. I'm not concerned with users of python3.5 and older python3. For all I know, they must have explicitly chosen that older version of python3. I'm concerned about python2 users, though. Not everybody has made the switch away from python2, yet. Bionic actually still uses python2 by default and I wouldn't be surprised if other stability-minded OS are in the same situation.

I don't feel at ease that those users are provided with software without an indication of its lack of support and more importantly without indication that there is an easy way for them to get supported software.

@leggewie leggewie added the bug label Jan 23, 2021
@leggewie leggewie changed the title issue python2 users with a warning warn users of the 3.x release of the unsupported status (especially python2 users) Jan 23, 2021
@leggewie leggewie changed the title warn users of the 3.x release of the unsupported status (especially python2 users) warn users of the 3.x release of the unsupported status Jan 23, 2021
@leggewie
Copy link
Contributor Author

I got a little further now and will push a few more commits to my branch.

@kdeldycke
Copy link
Owner

I'm surprised by your extra care about an old and obsolete version but I appreciate the effort nonetheless! 🙂

I guess your proposal is a good way to discover and start playing with the code base so that might indeed be a good starting exercise! 😀

I just created a v3 branch to the repository, so you can propose your changes against that in a PR.

@leggewie
Copy link
Contributor Author

leggewie commented Jan 23, 2021

Thank you very much for the v3 branch. I am not yet ready to tout success, but I've made a couple more steps in the right direction.

I'm an LTS kind of guy. I don't like my machine changing underneath me all the time, requiring my attention to fix the latest stuff. I also like to polish things up, so this was something I ran across while trying to do meaningful work with mdedup on my bionic system.

"Real devs" might have the bleeding edge of everything, but I am fairly certain the majority of the ordinary users regularly run into preventable grief.

@leggewie
Copy link
Contributor Author

leggewie commented Jan 24, 2021

It works:

asciicast

@kdeldycke
Copy link
Owner

mail-deduplicate v3.0.1 has just been released:

We can now close this issue.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2021
@kdeldycke kdeldycke added 📚 documentation Update to non-code (readme, docstrings, typos, …) and removed documentation labels Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📚 documentation Update to non-code (readme, docstrings, typos, …)
Projects
None yet
Development

No branches or pull requests

2 participants