-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added configurable color selector #5
Conversation
@kdnk do you suggest adding more information on colors available |
@cibinmathew Thanks for creating this PR 🙂 |
Updated |
@cibinmathew Thanks! |
|
This PR would work only for the 9 listed scopes in sublime_text_highlighter/highlighter.py Lines 124 to 134 in e0991eb
I have added the list of the scopes in Readme. Probably can work on another PR later to add support to more scopes/colors. |
{ "keys": ["ctrl+super+h"], "command": "text_highlighter_clear_all" } | ||
``` | ||
|
||
### Available colors by scope |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kdnk available colors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized that readme😄. But I meant users can still path any scopes, and it might cause runtime errors if users passes scopes which are not listed on the readme. Am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But... the current implementation might be sufficient😄 If we have proper safeguards in place for cases where users use non-listed colors, the plugin will still not work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!!
Added configurable color selector while defining commands/hotkeys. Previously a random available color was used. Now one can specify the color(colors are mapped based on scope)