This repository has been archived by the owner on Dec 18, 2023. It is now read-only.
Discard trailing punctuation before quoting fields #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user writes a single-field enum variant with a trailing comma, then keeping the trailing comma will cause us to quote a single-element tuple.
|
Thanks! |
snejugal
added a commit
to tbot-rs/tbot
that referenced
this pull request
Jul 4, 2021
Rust 1.53 introduced an intentional breaking change in attribute handling in macros, and it led to `is-macro` incorrectly generating code for `errors::HttpsWebhook::Tls` (investigated in [rust-lang/rust#85692]). A fix for that landed in `is-macro` 0.1.9 via [kdy1/is-macro#8], so `tbot` needs to require `is-macro` to be of version `^0.1.9`. [rust-lang/rust#85692]: rust-lang/rust#85692 [kdy1/is-macro#8]: kdy1/is-macro#8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user writes a single-field enum variant with a trailing comma,
then keeping the trailing comma will cause us to quote a single-element
tuple.