Unmount bug fix #108
Closed
Unmount bug fix #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, it's indeed weird that this is happening. Is there a chance you could also add a test case, which this fix then fixes? Or is this a hard to track error? |
|
Hey, this took way too long to get in, but it's merged now via #123 (had to rebase) and out with Kea 2.3.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @mariusandra not sure how
byActionworks or whybyAction[action]is ever falsey but it sometimes is and when it is, I get lots of errors so I added this check and the errors go away. I noticed this behavior when I started callingresetContextmultiple times. On the nth call, it unmounts the previous logics and sometimesbyActionis falsely and errors get thrown.