Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dynamic connect tests #80

Closed
wants to merge 2 commits into from

Conversation

ingoclaro
Copy link

@ingoclaro ingoclaro commented Feb 18, 2018

some tests for #72
Is there anything you would like to see tested? happy to add more cases.

@ingoclaro
Copy link
Author

as a side note, should we setup some CI project in github to run all tests?

},
},
],
dogOwners: [
Copy link
Author

@ingoclaro ingoclaro Feb 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this currently doesn't work, my intention was to update the connected prop setup above:

connect: {
  props: [
    //...
    store => store, ['dogOwners'],
  ],

dunno if this would be in scope for kea or not, since that branch of the store is outside the control of kea... any recommendation on how to update it? Basically how can I create a generic reducer that handles kea actions?

I guess this is a separate feature, should I open a new issue for that?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I know this could be solved, by using path the logic can be mounted wherever you want.

@ingoclaro ingoclaro closed this Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant