Ensure preloadedState is immutable on store create #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `getStore` in kea, the `preloadedState` is used as-is, allowing external actors to change the store underneath redux' nose. This specifically WILL happen when using Kea with Next, since the store is created once on the client and new data pushed into it via the Next.js update mechanism. The result is that `react-redux` believes the object has not changed, and components do not update. Worse, the store is globally available on Window, and the result is that a malicious script would be able to change the store the app believes it is using, without its knowledge. This change ensures that cannot happen, and retains the redux guarantee of state immutability.
|
Hey, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
getStorein kea, thepreloadedStateis used as-is, allowing external actors to change the store underneath redux' nose. This specifically WILL happen when using Kea with Next, since the store is created once on the client and new data pushed into it via the Next.js update mechanism. The result is thatreact-reduxbelieves the object has not changed, and components do not update.Worse, the store is globally available on Window, and the result is that a malicious script would be able to change the store the app believes it is using, without its knowledge.
This change ensures that cannot happen, and retains the redux guarantee of state immutability.