Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAB-27 Allow scoped token to create storage tokens #241

Conversation

tomasfejfar
Copy link
Contributor

@tomasfejfar tomasfejfar commented Apr 16, 2024

Jira: KAB-27
Connection PR: https://github.com/keboola/connection/pull/4961

Before asking for review make sure that:

Checklist

  • New client method(s) has tests
  • Apiary file is updated
  • You declared if there is a BC break or not (will affect next release of a client)

Release

  • I gave the PR a proper label:
    • major (BC break)
    • minor (new feature)
    • patch (backwards compatible fix)
    • no release (just test changes)

@tomasfejfar tomasfejfar added the minor new feature label Apr 17, 2024
@tomasfejfar tomasfejfar requested review from a team and jirkasemmler and removed request for a team April 17, 2024 08:45
@@ -17,6 +17,7 @@ services:
- KBC_MANAGE_API_SUPER_TOKEN_WITH_PROJECTS_READ_SCOPE
- KBC_MANAGE_API_SUPER_TOKEN_WITH_DELETED_PROJECTS_READ_SCOPE
- KBC_MANAGE_API_SUPER_TOKEN_WITHOUT_SCOPES
- KBC_MANAGE_API_SUPER_TOKEN_WITH_STORAGE_TOKEN_SCOPE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prosim pridej a popis ho do README.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apiary jsem měl upravené, ale zapomněl jsem pushnout 🤦

@jirkasemmler
Copy link
Contributor

jirkasemmler commented Apr 17, 2024

jo a prosim chtelo by to pridat jeste sem https://keboolamanagementapi.docs.apiary.io/#reference/projects/create-storage-token-in-project/create-storage-token nejakou poznamku, ze to jde tim scopovanym tokenem

Creating bucket is not a good candidate as the project does not have backend.
@tomasfejfar tomasfejfar force-pushed the KAB-27-allow-creating-storage-token-using-application-token-with-scope branch from efc069f to ff9ed4b Compare April 17, 2024 18:29
@tomasfejfar tomasfejfar force-pushed the KAB-27-allow-creating-storage-token-using-application-token-with-scope branch from ff9ed4b to 5ae5696 Compare April 17, 2024 18:30
@jirkasemmler jirkasemmler merged commit f5d8874 into master Apr 18, 2024
3 checks passed
@jirkasemmler jirkasemmler deleted the KAB-27-allow-creating-storage-token-using-application-token-with-scope branch April 18, 2024 05:52
@tomasfejfar tomasfejfar added no release just test changes and removed minor new feature labels Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no release just test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants