Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAB-88 Test org detail and project list with scoped app token #249

Merged
merged 1 commit into from
May 9, 2024
Merged

KAB-88 Test org detail and project list with scoped app token #249

merged 1 commit into from
May 9, 2024

Conversation

tomasfejfar
Copy link
Contributor

@tomasfejfar tomasfejfar commented May 7, 2024 •
edited
Loading

Jira: KAB-88
Connection PR: https://github.com/keboola/connection/pull/5036

Before asking for review make sure that:

Checklist

  • New client method(s) has tests
  • Apiary file is updated
  • You declared if there is a BC break or not (will affect next release of a client)

Release

  • I gave the PR a proper label:
    • major (BC break)
    • minor (new feature)
    • patch (backwards compatible fix)
    • no release (just test changes)

@tomasfejfar tomasfejfar added the no release just test changes label May 7, 2024
@tomasfejfar tomasfejfar requested review from jirkasemmler and romanbracinik and removed request for jirkasemmler May 7, 2024 13:55
romanbracinik
romanbracinik approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@romanbracinik romanbracinik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@romanbracinik romanbracinik merged commit ade480a into master May 9, 2024
3 checks passed
@romanbracinik romanbracinik deleted the KAB-88-allow-calling-manage-organizations-id-with-scoped-application-token branch May 9, 2024 07:23
@tomasfejfar tomasfejfar mentioned this pull request May 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanbracinik romanbracinik romanbracinik approved these changes

Assignees
No one assigned
Labels
no release just test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomasfejfar @romanbracinik