Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve registration of abckend docs #253

Merged
merged 1 commit into from
May 21, 2024
Merged

Improve registration of abckend docs #253

merged 1 commit into from
May 21, 2024

Conversation

tomasfejfar
Copy link
Contributor

@tomasfejfar tomasfejfar commented May 20, 2024 •
edited
Loading

https://keboolaglobal.slack.com/archives/C011BERCEBG/p1716205950886249?thread_ts=1716199741.223089&cid=C011BERCEBG

Before asking for review make sure that:

Checklist

  • New client method(s) has tests
  • Apiary file is updated
  • You declared if there is a BC break or not (will affect next release of a client)

Release

  • I gave the PR a proper label:
    • major (BC break)
    • minor (new feature)
    • patch (backwards compatible fix)
    • no release (just test changes)

pivnicek
pivnicek approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@pivnicek pivnicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tom!!!

@tomasfejfar tomasfejfar requested review from a team, martinjandl and zajca and removed request for a team and martinjandl May 20, 2024 12:05
@tomasfejfar tomasfejfar merged commit 3c7ee44 into master May 21, 2024
3 checks passed
@tomasfejfar tomasfejfar deleted the tomasfejfar-patch-1 branch May 21, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zajca zajca zajca approved these changes

@pivnicek pivnicek pivnicek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomasfejfar @zajca @pivnicek