Provide capability to specify annotations in Helm chart

[tomkerkhove]

Signed-off-by: Tom Kerkhove kerkhove.tom@gmail.com

Closes #26

[ncrothe]

That should work. Comparing this to the image values, I would suggest using annotation.keda and annotation.metricsAdapter for consistency. Also, I would suggest podAnnotation instead of plain annotation as the chart might end up with serviceAnnotations etc. at some point.

On a more general note: Looking at the structure of the values section, the multi-component nature of the chart and other charts I have seen, I do, however, think you might want to consider switching from a property.component structure to component.property eventually.

I.e. from

annotations:
  operator:
  apiserver:

etc. to something like

operator:
  image:
  replicaCount:
  podAnnotations:
metrics:
  image:
  replicaCount:
  podAnnotations:

Though this does go well beyond the scope of an MR like this and would also break existing deployments. But something to consider for a future version bump.

[ncrothe]

Sorry, did not realise github ate the angular brackets in last line of second paragraph. Fixed my suggestion to reflect. @tomkerkhove

[ncrothe]

@ahmelsayed Is it possible to make a timely 1.3.1 release of the chart? Because this fix would go really well with the annotation-based podIdentity stuff in the 1.3.0 release of the operator.

[ahmelsayed]

@ncrothe Done :)

[ncrothe]

As pointed out in kedacore/keda#706 the annotations ended up in the wrong place. The are currently in the deployments' metadata, but need to go into the spec's metadata, i.e. to spec.template.metadata.