Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the example for Cron Scaler match the screenshot #1330

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

ecerulm
Copy link
Contributor

@ecerulm ecerulm commented Mar 7, 2024

The example now match the screenshot

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@ecerulm ecerulm requested a review from a team as a code owner March 7, 2024 07:23
Copy link

github-actions bot commented Mar 7, 2024

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link

netlify bot commented Mar 7, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 9711e81
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/65e9b2189210b10008094463
😎 Deploy Preview https://deploy-preview-1330--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ecerulm ecerulm changed the title Make the example match the screenshot Make the example for Cron Scaler match the screenshot Mar 7, 2024
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, great, could you please also fix other versions? Thanks

@ecerulm
Copy link
Contributor Author

ecerulm commented Mar 7, 2024

I like it, great, could you please also fix other versions? Thanks

I'm not sure I understand what you meant, I update the other example the one about having same start and end, but I have the feel that that is probably not what you meant by "other versions".

@zroubalik
Copy link
Member

You fixed this in version 2.13, would be great if we can fix this also in other version (2.14, 2.12,...)

Signed-off-by: Ruben Laguna <ruben.laguna@gmail.com>
@ecerulm
Copy link
Contributor Author

ecerulm commented Mar 7, 2024

You fixed this in version 2.13, would be great if we can fix this also in other version (2.14, 2.12,...)

Got you now, I added the changes in all other versions now.

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zroubalik zroubalik merged commit 4952a9d into kedacore:main Mar 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants