Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update external-scaler docs to align current interfaces #1353

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Update external-scaler docs to align current interfaces #1353

merged 1 commit into from
Apr 10, 2024

Conversation

JorTurFer
Copy link
Member

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #1349

@JorTurFer
Update scaler interface and relations
16cb67f 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer requested a review from a team as a code owner April 4, 2024 21:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@netlify Netlify
Copy link

netlify bot commented Apr 4, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 16cb67f
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/660f17edafda5e00084fdde1
😎 Deploy Preview https://deploy-preview-1353--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JorTurFer JorTurFer enabled auto-merge (squash) April 4, 2024 21:16
zroubalik
zroubalik approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did we miss this?

@JorTurFer JorTurFer merged commit 4c71ab2 into kedacore:main Apr 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

external-scaler documentation seems to be out of date
2 participants
@JorTurFer @zroubalik