Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logTimeFormat is not present in KEDA v2, encoder is #45

Closed
zroubalik opened this issue Nov 2, 2020 · 0 comments
Closed

logTimeFormat is not present in KEDA v2, encoder is #45

zroubalik opened this issue Nov 2, 2020 · 0 comments
Assignees
@samuelmacko

Comments

@zroubalik
Copy link
Member

logTimeFormat was removed but zap-encoder was added: https://github.com/kedacore/keda/blob/main/BUILD.md#keda-operator-logging

We should modify the KedaController resource, the property for zap-encoder should be probably named logEncoder

keda-olm-operator/api/v1alpha1/kedacontroller_types.go

Line 38 in e42474f

LogTimeFormat string `json:"logTimeFormat,omitempty"`

Don't forget to update Readme and samples in config/samples
https://github.com/kedacore/keda-olm-operator#kedacontroller-spec
@zroubalik zroubalik mentioned this issue Nov 2, 2020
Closed
@samuelmacko samuelmacko mentioned this issue Nov 4, 2020
Merged
joelsmith pushed a commit to joelsmith/keda-olm-operator that referenced this issue Sep 7, 2023
@openshift-merge-robot
Merge pull request kedacore#45 from joelsmith/main
aa41844 
OCPBUGS-15590: Use KEDA-specific annotation name for last config, part 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samuelmacko samuelmacko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zroubalik @samuelmacko