generalized replacing container arguments #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: smacko <samuel.macko.sm@gmail.com>
zroubalik
requested changes
Apr 23, 2020
| @@ -205,6 +201,14 @@ func EnsureCertInjectionForDeployment(configMapName string, secretName string, s | |||
| } | |||
| } | |||
|
|
|||
| func AddPathsToCerts(values []string, prefixes []Prefix, scheme *runtime.Scheme, logger logr.Logger) []mf.Transformer { | |||
There was a problem hiding this comment.
I'd name this something like EnsurePathsToCertsInDeployment just because of consistency with other similar functions
| @@ -302,6 +306,11 @@ func (r *ReconcileKedaController) installMetricsServer(instance *kedav1alpha1.Ke | |||
| transform.EnsureCertInjectionForService(metricsServcerServiceName, injectservingCertAnnotation, injectservingCertAnnotationValue, r.scheme, log), | |||
| transform.EnsureCertInjectionForDeployment(metricsServerConfigMapName, metricsServcerServiceName, r.scheme, log), | |||
| } | |||
|
|
|||
| argsPrefixes := []transform.Prefix{transform.ClientCAFile, transform.TLSCertFile, transform.TLSPrivateKeyFile} | |||
There was a problem hiding this comment.
I'd move argsPrefixes and newArgs definition somewhere around line 302, before transforms := []mf.Transformer{.
Then move transforms = append(transforms, transform.AddPathsToCert... directly inside the transforms defintion.
To keep the code consistent
Signed-off-by: smacko <samuel.macko.sm@gmail.com>
joelsmith
pushed a commit
to joelsmith/keda-olm-operator
that referenced
this pull request
Mar 20, 2023
OCPNODE-1499: Add support for must-gather collection script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15
Signed-off-by: smacko samuel.macko.sm@gmail.com