Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation to link to new Openshift 4 sample #625

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Update documentation to link to new Openshift 4 sample #625

merged 1 commit into from
Feb 13, 2020

Conversation

tomkerkhove
Copy link
Member

Checklist

  • A PR is opened to update the documentation

@tomkerkhove
Copy link
Member Author

@ahmelsayed I have a notification saying that release build failed, any thoughts why this PR triggered that one? Could it be because of the v in my name? Don't think it's that? 🤔

@ahmelsayed
Copy link
Contributor

Looks like 'create' event also happens on branch creates (https://github.community/t5/GitHub-Actions/How-to-run-GitHub-Actions-Workflow-only-for-new-tags/td-p/29413)

#627

@ahmelsayed ahmelsayed merged commit 5e82ec7 into master Feb 13, 2020
@ahmelsayed ahmelsayed deleted the tomkerkhove-patch-1 branch February 13, 2020 09:11
@SatishRanjan SatishRanjan mentioned this pull request Mar 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmelsayed ahmelsayed ahmelsayed approved these changes

@Aarthisk Aarthisk Awaiting requested review from Aarthisk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomkerkhove @ahmelsayed