Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Running kedge generate/deploy returns nothing, expected error #96

Closed
concaf opened this issue Jun 29, 2017 · 3 comments
Closed

Running kedge generate/deploy returns nothing, expected error #96

concaf opened this issue Jun 29, 2017 · 3 comments
Assignees
@concaf
Labels
help wanted kind/bug kind/task kind/user-experience priority/high

Comments

@concaf
Copy link
Collaborator

concaf commented Jun 29, 2017

Running plain kedge deploy should return an error that no file specified, or something similar but currently it return nothing -

💢concaf kedge (master) $ kedge deploy
💢concaf kedge (master) $
@kadel
Copy link
Member

kadel commented Jun 29, 2017 •
edited
Loading

kedge generate has the same issue

@concaf concaf changed the title Running kedge deploy returns nothing, expected error Running kedge generate/deploy returns nothing, expected error Jul 3, 2017
@kadel
Copy link
Member

kadel commented Jul 11, 2017

we should make -f/--file flag required. If it's not set we show help for given command.

kedge generate should display same output as kedge generate -h and similarly for kedge deploy should display same output as calling kedge deploy -h

We should also add a note to -f stating that this flag is required.

@concaf concaf mentioned this issue Jul 12, 2017
Closed
@concaf concaf self-assigned this Jul 12, 2017
@concaf
Copy link
Collaborator Author

concaf commented Jul 12, 2017

@kadel +1. Once #147 is resolved, will fix this.

concaf added a commit to concaf/kedge that referenced this issue Jul 12, 2017
@concaf
kedge <subcommand> errors out without -f/--files
ac3250a 
Before this commit, running `kedge` subcommands without passing
any files would do nothing.

$ kedge deploy
$

$ kedge generate
$

$ kedge undeploy
$

This commit adds a check that input files are passed using -f or
--files flags, and if not, throws an error.

$ kedge generate
Error: Unable to validate input files: No files were passed. Please pass file(s) using '-f' or '--files'

The flags have also been marked as required, however, that takes
no effect, and there is an open issue on the spf13/cobra package
tracking the same - spf13/cobra#206

Fixes kedgeproject#96
concaf added a commit to concaf/kedge that referenced this issue Jul 12, 2017
@concaf
kedge <subcommand> errors out without -f/--files
7a0b047 
Before this commit, running `kedge` subcommands without passing
any files would do nothing.

$ kedge deploy
$

$ kedge generate
$

$ kedge undeploy
$

This commit adds a check that input files are passed using -f or
--files flags, and if not, throws an error.

$ kedge generate
Error: Unable to validate input files: No files were passed. Please pass file(s) using '-f' or '--files'

The flags have also been marked as required, however, that takes
no effect, and there is an open issue on the spf13/cobra package
tracking the same - spf13/cobra#206

Fixes kedgeproject#96
@kadel kadel mentioned this issue Jul 13, 2017
Merged
@concaf concaf mentioned this issue Jul 14, 2017
Open
@kadel kadel closed this as completed in aa0c09a Jul 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@concaf concaf

Labels
help wanted kind/bug kind/task kind/user-experience priority/high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kadel @pradeepto @surajssd @concaf