This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
Remove replicas from main app struct #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadel
reviewed
Jul 12, 2017
pkg/cmd/deploy.go
Outdated
| @@ -21,10 +21,9 @@ import ( | |||
| "io" | |||
| "os/exec" | |||
|
|
|||
| "github.com/ghodss/yaml" | |||
There was a problem hiding this comment.
This constant changing order of imports is starting to get messy.
We should do something with it.
Can we agree on having 3 blocks of imports, stdlib, gihtub.com/kedgeproject/kedge, and other?
There was a problem hiding this comment.
Other being 3rd party libraries? If so, then +1. Have followed that in previous projects. Totally makes sense. This policy, if agreed upon, should go into the development doc.
There was a problem hiding this comment.
yep, by other I meant 3rd party libs
There was a problem hiding this comment.
or it can be stdlib, 3rd party, our packages
important is that we keep the same order in all the files
Since we are already embedding DeploymentSpec in App struct we don't need Replicas anymore, this was added when we never had any field to specify replicas.
surajssd
force-pushed
the
remove_replicas
branch
from
91e715e
to
a2dd89a
Compare
|
@kadel arranged the imports as you asked: |
kadel
approved these changes
Jul 13, 2017
This was referenced Jul 24, 2017
This was referenced Sep 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are already embedding DeploymentSpec in App struct we don't need Replicas anymore, this was added when we never had any field to specify replicas.
Fixes #100