New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge training #4

Closed

astrojuanlu wants to merge 76 commits into main from merge-training

Member

astrojuanlu commented Feb 27, 2023 •

edited

Loading

Merge all material from https://github.com/kedro-org/kedro-training in a training directory, retaining git history thanks to https://github.com/newren/git-filter-repo.

Made one small note to the README on top of the current history.

Addresses kedro-org/kedro-devrel#39.


          Copy content from kedro-examples

b560515

astrojuanlu requested review from stichbury and yetudada

February 27, 2023 17:47

Member Author

astrojuanlu commented Feb 27, 2023

Now the key question: should I

Signoff all the commits myself,
Manually signoff each commit by their author (sounds like bad idea legally speaking), or
Give up on retaining the history and squash everything (😢)?

This was referenced Feb 27, 2023

Add note about archiving repository kedro-org/kedro-training#27

Merged

Archive content on the kedro-training repo and sunset it kedro-org/kedro-devrel#39

Closed

astrojuanlu force-pushed the merge-training branch from 3073092 to 2606dee Compare

February 27, 2023 18:24

Member Author

astrojuanlu commented Feb 27, 2023

According to https://github.com/git/git/blob/b2c150d3aa82f6583b9aadfecc5f8fa1c74aca09/Documentation/git-commit.txt#L154-L161 (source):

The meaning of a signoff depends on the project, but it typically certifies that committer has the rights to submit this work under the same license and agrees to a Developer Certificate of Origin (see https://developercertificate.org/ for more information).

And from https://probot.github.io/apps/dco/ and https://developercertificate.org/,

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

So my understanding is that I can assume under (b) that I can sign-off everything. Happy to learn more otherwise.

stichbury reviewed

View reviewed changes

training/README.md Outdated Show resolved Hide resolved

stichbury reviewed

View reviewed changes

training/README.md Outdated Show resolved Hide resolved

stichbury approved these changes

View reviewed changes

Contributor

stichbury left a comment

LGTM

stichbury and others added 19 commits

February 28, 2023 13:05


          Initial commit

6a03818

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          Update README.md

4db5ecd

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          Update .gitignore

0e0c6ea

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          Create README.md

17dc05a

Signed-off-by: Juan Luis Cano Rodríguez <juan_cano@mckinsey.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          Update attendee_list.md

118d00b

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          Create attendee_list.md

e5ac092

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          Remove old file

7d8cddc

Signed-off-by: Juan Luis Cano Rodríguez <juan_cano@mckinsey.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          Merge pull request #1 from kedro-org/update_attendee_list

88eb838

Update attendee_list.md


          Updated Example S3 Credentials management

7daa7ae

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          Merge branch 'master' into patch-1

6d827e7


          empty

8eee11c

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          Add credentials.yml file

fb07252

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          Update content to latest Kedro (#1)

70fbe44

* Updates to kedro version and add tutorial data

* Use latest kedro version

* Add CCI jobs for linting + security check, apply isort and black

* Fix links

* Update kedro viz installation link

* Add requirements for cci

* Update spaceflight template to be the same as kedro-starter-spaceflights

* Remove tutorial data, as it's a step of the exercise

* Revert "Remove tutorial data, as it's a step of the exercise"

This reverts commit 8f5a5e7174262886af8c8c252837180c4d957883.

* Rename requirements to test_requirements

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          pass DataFrame instead of dict to catalog.context.save

387a1e9

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          empty

e664aba

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          Merge pull request #2 from quantumblacklabs/add-credentials-file

c321e91

Add credentials.yml file to the tutorial repo, since we explain how to manage credentials in the docs.


          Merge branch 'master' into master

591fb9b


          Merge pull request #4 from csaranbalaji/patch-1

a4514bd


          Fix expected project name in test_project_name

9d3b206

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

antonymilne and others added 24 commits

February 28, 2023 13:05


          Update .gitpod.yml

a72eabc

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          Update 06_jupyter_notebook_workflow.md

b786240

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          Delete old img

b1b0e8e

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          Merge branch 'master' into docs/create-new-training-folder

df464a9


          Update to latest spaceflights tutorial code

d7cc1e1

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          Update 13_custom_datasets.md

db37028

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          Minor corrections

ab0db5c

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          Remove old version of documentation for training. New version in `tra…

0d4ac74

…ining_docs`

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          Update 01_welcome.md

e9ad00a

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          Feedback from PR review

407ddbc

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          Merge pull request #14 from quantumblacklabs/docs/update-training-feb…

a2b066e

…2021

Delete kedro-exercises from kedro-training 🔥


          Revert to original prerequisites and structure

0123f38

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          Merge pull request #15 from quantumblacklabs/docs/create-new-training…

f1efdf6

…-folder

Update readme and add new training materials


          Apply suggestions from code review

5480f79

Co-authored-by: Lorena Bălan <lorena.balan@quantumblack.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          Merge pull request #18 from AntonyMilneQB/update-for-0.17.2

1a04503

Update to kedro 0.17.2


          removed relevant references to QB

5d60710

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          Remove mention of kedro install (#20)

0c12ef5

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          Update training_docs/13_custom_datasets.md

5bb9e1e

Co-authored-by: Merel Theisen <49397448+MerelTheisenQB@users.noreply.github.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          Add PR template (#22)

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          Merge pull request #23 from kedro-org/docs/remove-references-to-quant…

cb3f3c6

…umblacklabs#ked-3046

[KED-3046] Remove "QuantumBlack Labs" from places where it doesn't belong any more


          Merge pull request #2 from astrojuanlu/main

ad92a47

Update basic exercise


          Merge remote-tracking branch 'training/main' into merge-training

fad343d

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          Minor modifications to training README

ad76ac1

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>


          Apply suggestions from code review

5ac08c0

Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

astrojuanlu closed this

astrojuanlu force-pushed the merge-training branch from 40d7496 to 5ac08c0 Compare

February 28, 2023 12:06

astrojuanlu pushed a commit that referenced this pull request


          Merge pull request #4 from csaranbalaji/patch-1

7b3405e

Member Author

astrojuanlu commented Feb 28, 2023

Sorry, my git black magic is failing me. Opening a new PR.

astrojuanlu mentioned this pull request

Merge training, take 2 #5

Merged

Member Author

astrojuanlu commented Feb 28, 2023

Continued in gh-5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet