Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip pyproject.toml and requirements.txt in starters so it can be used by add-ons #171

Closed
wants to merge 2 commits into from

Conversation

SajidAlamQB
Copy link
Contributor

@SajidAlamQB SajidAlamQB commented Oct 26, 2023

Motivation and Context

Related to: kedro-org/kedro#3169
Related comment: kedro-org/kedro#3169 (comment)

The pyproject.toml and requirements.txt files in the starters should contain the minimum so that they don't contain any "add-ons" related stuff by default.

Development Notes

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Assigned myself to the PR
  • Added tests to cover my changes

Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
@SajidAlamQB
Copy link
Contributor Author

@merelcht I've stripped the requirements.txt and pyproject.toml of the test, docs, and lint add-ons. It got me wondering about the tests/ and docs/ directories now that their requirements are gone do we want to remove them as well?

@merelcht merelcht deleted the strip-requirements branch November 13, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant