Add svg logo resource for ipython #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhdraMeraliQB
force-pushed
the
fix/add-svg-logo
branch
from
d685ff7
to
98a1f2e
Compare
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
|
Closed accidentally 😅 |
added 3 commits
September 15, 2022 17:12
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
antonymilne
approved these changes
Sep 16, 2022
There was a problem hiding this comment.
Thank you for fixing this! A couple of quick checks:
- if you do
make package, is the svg definitely included in the .whl file? (I'm very confident it is, owing to the change to MANIFEST.in, but it's worth being absolutely sure because otherwise when youpip installkedro from a released package thekedro jupytercommands would not work) - a quick screenshot of our beautiful high fidelity zoomed in logo on Jupyter lab would be nice 🙂 I wonder if we should crop the svg (still keeping it square) since at a glance it seems like it might have quite a big empty space round it?
Co-authored-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
jmholzer
approved these changes
Sep 16, 2022
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
|
@AntonyMilneQB
It is! 🎊
Here's a look at the logo at 400% zoom, sharp as ever:
Cropped the logo as suggested to get rid of some (but not all) of the whitespace, let me know if it needs more of a chop ✂️ |
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
|
Looks perfect, thank you! |
nickolasrm
pushed a commit
to ProjetaAi/kedro
that referenced
this pull request
Oct 26, 2022
* Add resource Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Include file in kernel Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Lint Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Fix tests Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Lint (again) Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Alphabetise resources Co-authored-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * Crop logo svg Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Crop logo svg more Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> Co-authored-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Signed-off-by: nickolasrm <nickolasrochamachado@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jupyterlab now prioritises a
logo-svg.svgfile above.pngfiles in their launcher (see: this issue on jupyterlab). Without including this file, the Kedro logo is replaced by the Python logo that is automatcally included by ipykernel as of6.15.3. This PR adds this file in order to prevent the Kedro logo from being replaced.Checklist
RELEASE.mdfile