-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecation notice to archived starters #3173
Conversation
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @ankatiyar! 👍
Sorry I missed this - what is the replacement for the pyspark starter? This affects most of the QB Verticals |
I believe it will be replaced by, https://github.com/kedro-org/kedro-starters/tree/main/spaceflights-pyspark, it was introduced by @merelcht with a new suite of starters that use spaceflights as a base. |
It would also be useful to add the deprecation mention to
|
So I want to strongly argue we shouldn't delete the empty pyspark starter- the verticals need any empty template to build off |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a breaking change for many QB Vertical workflows
@datajoely I was under the impression that you can create an empty |
This would break the existing Alloy workflow - can you follow all the add on steps from a single command? It won't work if it's an interactive pattern. |
@datajoely Yeah, I believe it'll be |
Either way it would make things a lot easier to keep this existing cookie cutter version I think |
The main risk is that existing users refuse to go to 0.19.x because of this |
Yes, the new add-ons flow will have an option to create an empty |
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
I would strongly request that we keep both the pyspark and blank Kedro starters in cookiecutter format as is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
Discussed with the team that the deprecation warnings will still go in, because they're blocking the |
* Add deprecation notice to archived starters Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Add '(deprecated)' to the names of the starters Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> --------- Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Signed-off-by: Adam Kells <adamjkells93@gmail.com>
Description
Close #3114
Development notes
kedro starter list
is usedkedro new
command.Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file