Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pipeline test location to project root/tests #3731

Merged
merged 15 commits into from
Apr 3, 2024

Conversation

lrcouto
Copy link
Contributor

@lrcouto lrcouto commented Mar 21, 2024

Description

Development notes

Changes the location in which tests for pipelines are created with the command kedro pipeline create, from <project root>/src/tests/pipelines/<pipeline name> to <project root>/tests/pipelines/<pipeline name>. This change was made to match the template used by the starters, avoiding creating two separate directories for tests.

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

lrcouto and others added 6 commits March 21, 2024 18:32
Signed-off-by: lrcouto <laurarccouto@gmail.com>
Signed-off-by: lrcouto <laurarccouto@gmail.com>
Signed-off-by: lrcouto <laurarccouto@gmail.com>
Signed-off-by: lrcouto <laurarccouto@gmail.com>
@noklam
Copy link
Contributor

noklam commented Mar 26, 2024

  • where 1 = <Result ValueError("'/tmp/tmpq_u_2key/dummy_project/tests/pipelines/my_pipeline' is not in the subpath of '/tmp/tmpq_u_2key/dummy_project/src' OR one path is relative and the other is absolute.")>.exit_code

I saw this everywhere which is related to the ticket that I am working on. See:

However, I don't think this is the problem, but you can try to cherrypick my commits at #3742 to see if it solves the problem. I suspect is the test fixtures need some update but I only look at it for 2 mins so I don't know where it should be.

Signed-off-by: lrcouto <laurarccouto@gmail.com>
@lrcouto
Copy link
Contributor Author

lrcouto commented Mar 26, 2024

  • where 1 = <Result ValueError("'/tmp/tmpq_u_2key/dummy_project/tests/pipelines/my_pipeline' is not in the subpath of '/tmp/tmpq_u_2key/dummy_project/src' OR one path is relative and the other is absolute.")>.exit_code

I saw this everywhere which is related to the ticket that I am working on. See:

* [Symlink resolution during configuration detection might break some CLI commands #2346](https://github.com/kedro-org/kedro/issues/2346)

However, I don't think this is the problem, but you can try to cherrypick my commits at #3742 to see if it solves the problem. I suspect is the test fixtures need some update but I only look at it for 2 mins so I don't know where it should be.

I think I found the source of the issue, the function that handles kedro micropkg package was still referring to the old path. I think most of the tests should pass now.

Signed-off-by: lrcouto <laurarccouto@gmail.com>
Signed-off-by: lrcouto <laurarccouto@gmail.com>
Signed-off-by: lrcouto <laurarccouto@gmail.com>
@lrcouto lrcouto marked this pull request as ready for review March 27, 2024 13:59
@lrcouto lrcouto linked an issue Mar 27, 2024 that may be closed by this pull request
@merelcht merelcht mentioned this pull request Apr 2, 2024
10 tasks
@ankatiyar
Copy link
Contributor

Tested this and it works well, but I think there is still a little inconsistency between the starters and the kedro pipeline create <pipeline_name> command -
Screenshot 2024-04-02 at 12 41 06

The test for data_science pipeline is under <root>/tests/pipelines/test_data_science.py but kedro pipeline create creates a folder inside <root>/tests/pipelines/<pipeline_name>/test_pipeline.py. Should we change the starters to match this format or maintain the flat structure where <root>/tests/pipelines/test_<pipeline_name>.py is created (and an __init__.py file if it doesn't exist)?

@ElenaKhaustova ElenaKhaustova self-requested a review April 2, 2024 15:35
Copy link
Contributor

@ElenaKhaustova ElenaKhaustova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my side - works well!

Agree with @ankatiyar comment regarding consistency.

@lrcouto
Copy link
Contributor Author

lrcouto commented Apr 2, 2024

Tested this and it works well, but I think there is still a little inconsistency between the starters and the kedro pipeline create <pipeline_name> command - Screenshot 2024-04-02 at 12 41 06

The test for data_science pipeline is under <root>/tests/pipelines/test_data_science.py but kedro pipeline create creates a folder inside <root>/tests/pipelines/<pipeline_name>/test_pipeline.py. Should we change the starters to match this format or maintain the flat structure where <root>/tests/pipelines/test_<pipeline_name>.py is created (and an __init__.py file if it doesn't exist)?

I think changing the starters to match the tests/ structures would be the best option. Having a separate directory for each pipeline would be more organized, allow tests for a specific pipeline to be found more easily, and allow for files containing utility functions or fixtures related do a specific pipeline's tests to be stored together with the test files.

@astrojuanlu
Copy link
Member

+1 to updating the starters according to what @ankatiyar and @lrcouto have said. Would that be a blocker for this particular PR? Or can we proceed and review & merge it?

@lrcouto
Copy link
Contributor Author

lrcouto commented Apr 3, 2024

+1 to updating the starters according to what @ankatiyar and @lrcouto have said. Would that be a blocker for this particular PR? Or can we proceed and review & merge it?

IMO we can merge this one and make the starter changes on another PR specific for them.

Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com>
Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Would be nice to get the changes to the starters also in this release, should be simple enough!

Copy link
Contributor

@ElenaKhaustova ElenaKhaustova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lrcouto lrcouto merged commit 5e9f7c2 into main Apr 3, 2024
41 checks passed
@lrcouto lrcouto deleted the update-kedro-pipeline-create-template branch April 3, 2024 19:58
AhdraMeraliQB pushed a commit that referenced this pull request Apr 17, 2024
* Change pipeline test location to project root/tests

Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Fix some test_pipeline tests

Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Change delete pipeline to account for new structure

Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Fix some tests

Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Change tests path on micropkg

Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Fix remaining tests

Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Add changes to release notes

Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Update file structure on micropackaging doc page

Signed-off-by: lrcouto <laurarccouto@gmail.com>

---------

Signed-off-by: lrcouto <laurarccouto@gmail.com>
Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
AhdraMeraliQB added a commit that referenced this pull request Apr 17, 2024
)

* Update kedro-catalog-0.19.json (#3724)

* Update kedro-catalog-0.19.json

Signed-off-by: Anthony De Bortoli <anthony.debortoli@protonmail.com>

* Update set_up_vscode.md

Signed-off-by: Anthony De Bortoli <anthony.debortoli@protonmail.com>

---------

Signed-off-by: Anthony De Bortoli <anthony.debortoli@protonmail.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Update project tests directory structure in docs

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Add docs on writing tests

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Drop dependency on toposort in favour of built-in graphlib (#3728)

* Replace toposort with graphlib (built-in from Python 3.9)

Signed-off-by: Ivan Danov <idanov@users.noreply.github.com>

* Create toposort groups only when needed

Signed-off-by: Ivan Danov <idanov@users.noreply.github.com>

* Update RELEASE.md and graphlib version constraints

Signed-off-by: Ivan Danov <idanov@users.noreply.github.com>

* Remove mypy-toposort

Signed-off-by: Ivan Danov <idanov@users.noreply.github.com>

* Ensure that the suggest resume test has no node ordering requirement

Signed-off-by: Ivan Danov <idanov@users.noreply.github.com>

* Ensure stable toposorting by grouping and ungrouping the result

Signed-off-by: Ivan Danov <idanov@users.noreply.github.com>

---------

Signed-off-by: Ivan Danov <idanov@users.noreply.github.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Optimise pipeline addition and creation (#3730)

* Create toposort groups only when needed
* Ensure that the suggest resume test has no node ordering requirement
* Ensure stable toposorting by grouping and ungrouping the result
* Delay toposorting until pipeline.nodes is used
* Avoid using .nodes when topological order or new copy is unneeded
* Copy the nodes only if tags are provided
* Remove unnecessary condition in self.nodes

Signed-off-by: Ivan Danov <idanov@users.noreply.github.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Expand robots.txt for Kedro-Viz and Kedro-Datasets docs (#3729)

* Add project to robots.txt

Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com>

* Add EOF

Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com>

---------

Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com>
Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Kedro need more uv (#3740)

* Kedro need more uv

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>

* remove docker

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>

---------

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Resolve all path in Kedro (#3742)

* Kedro need more uv

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>

* remove docker

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>

* fix broken type hint and resolve project path

Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>

* fix type hint

Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>

* remove duplicate logic

Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>

* adding nok.py is definitely an accident

Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>

* fix test

Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>

* remove print

Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>

* add test

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>

---------

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Remove settings of rate limits and retries (#3769)

* double linkcheck limits

Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>

* fix ratelimit

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>

---------

Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Improve resume suggestions (#3719)

* Improve suggestions to resume a failed pipeline

- if dataset (or param) is persistent & shared, don't keep looking for ancestors
- only look for ancestors producing impersistent inputs
- minimize number of suggested nodes (= shorter message for the same pipeline)
- testable logic, tests cases outside of scenarios for sequential runner

- Use _EPHEMERAL attribute
- Move tests to separate file
- Docstring updates

---------

Signed-off-by: Ondrej Zacha <ondrej.zacha@okra.ai>
Co-authored-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Build docs fix (#3773)

* Ignored forbidden url

Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>

* Returned linkscheck retries

Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>

* Removed odd comment

Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>

---------

Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Clarify docs around custom resolvers (#3759)

* Updated custom resolver docs section

Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>

* Updated advanced configuration section for consistency

Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>

* Updated RELEASE.md

Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>

* Updated RELEASE.md

Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>

* Test linkcheck_workers decrease

Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>

* Increased the By default, the linkcheck_rate_limit_timeout to default

Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>

* Returned old docs build settings

Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>

* Fixed typo

Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>

* Ignore forbidden url

Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>

* Returned linkcheck retries

Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>

---------

Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Add mlruns to gitignore to avoid pushing  mlflow local runs to github (#3765)

* Add mlruns to gitignore to avoid pushing  mlflow local runs to github

Signed-off-by: Yolan Honoré-Rougé <yolan.honore.rouge@gmail.com>

* update release.md

Signed-off-by: Yolan Honoré-Rougé <yolan.honore.rouge@gmail.com>

---------

Signed-off-by: Yolan Honoré-Rougé <yolan.honore.rouge@gmail.com>
Signed-off-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
Co-authored-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Update the dependencies page in the docs (#3772)

* Update the dependencies page

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>

* Update docs/source/kedro_project_setup/dependencies.md

Signed-off-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Signed-off-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com>

* Fix lint

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>

* Move the last line to notes

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>

---------

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Signed-off-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com>
Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Change pipeline test location to project root/tests (#3731)

* Change pipeline test location to project root/tests

Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Fix some test_pipeline tests

Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Change delete pipeline to account for new structure

Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Fix some tests

Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Change tests path on micropkg

Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Fix remaining tests

Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Add changes to release notes

Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Update file structure on micropackaging doc page

Signed-off-by: lrcouto <laurarccouto@gmail.com>

---------

Signed-off-by: lrcouto <laurarccouto@gmail.com>
Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Add an option for kedro new to skip telemetry (#3701)

* First draft for telemetry consent flag on kedro new

Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Add functioning --telemetry option to kedro new

Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Update tests to acknowledge new flag

Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Add tests for kedro new --telemetry flag

Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Add changes to documentation and release notes

Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Minor change to docs

Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Lint

Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Remove outdated comment and correct type hint

Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Update docs/source/get_started/new_project.md

Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com>

* Lint

Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Minor change on release note

Signed-off-by: lrcouto <laurarccouto@gmail.com>

---------

Signed-off-by: lrcouto <laurarccouto@gmail.com>
Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com>
Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Update documentation for OmegaConfigLoader (#3778)

* Update documentation for OmegaConfigLoader

Signed-off-by: Puneet Saini <99470400+puneeter@users.noreply.github.com>

* Update RELEASE.md

Signed-off-by: Puneet Saini <99470400+puneeter@users.noreply.github.com>

* Update RELEASE.md

Signed-off-by: Puneet Saini <99470400+puneeter@users.noreply.github.com>

* Update ignore-names.txt

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

---------

Signed-off-by: Puneet Saini <99470400+puneeter@users.noreply.github.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Fix path

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Lint

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Add changes to RELEASE.md

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Address comments from code review

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Empty

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Remove unneeded imports

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Change recommendation from pytest config to editable install

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Add negative testing example

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Replace Dict with dict

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Remove test classes

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Change the assert step for the integration test

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Fix error handling for OmegaConfigLoader (#3784)

* Update omegaconf_config.py

Signed-off-by: Puneet Saini <99470400+puneeter@users.noreply.github.com>

* Update RELEASE.md

Signed-off-by: Puneet Saini <99470400+puneeter@users.noreply.github.com>

* add a more complicated test case

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>

---------

Signed-off-by: Puneet Saini <99470400+puneeter@users.noreply.github.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Co-authored-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Add Simon Brugman to TSC (#3780)

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Update technical_steering_committee.md (#3796)

Signed-off-by: Marcin Zabłocki <m.zablo@gmail.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Remove jmespath dependency (#3797)

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Update spaceflights tutorial and starter requirements for kedro-datasets optional dependencies (#3664)

* Update spaceflights tutorial and starter requirements

Signed-off-by: lrcouto <laurarccouto@gmail.com>

* fix e2e tests

Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Fix e2e tests by distinguishing `kedro-datasets` dependency for different python versions (#3802)

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>

* Update docs/source/tutorial/tutorial_template.md

Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com>

---------

Signed-off-by: lrcouto <laurarccouto@gmail.com>
Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Consider Vale's suggestions

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Hide test in details

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Quick fix

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Typo (and wording changes)

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Update robots.txt (#3803)

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Add a test for transcoding loops of 1 or more nodes (#3810)

Signed-off-by: Ivan Danov <idanov@users.noreply.github.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Ensure no nodes can depend on themselves even when transcoding is used (#3812)

* Factor out transcoding helpers into a private module

Signed-off-by: Ivan Danov <idanov@users.noreply.github.com>

* Ensure node input/output validation doesn't allow transcoded self-loops

Signed-off-by: Ivan Danov <idanov@users.noreply.github.com>

* Updated release note to avoid github warning

Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>

---------

Signed-off-by: Ivan Danov <idanov@users.noreply.github.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Co-authored-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Update UUID telemetry docs (#3805)

Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Change path to starters test (#3816)

Signed-off-by: lrcouto <laurarccouto@gmail.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Move changes in RELEASE.md to docs section

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Change formatting

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Revert "Change formatting"

This reverts commit 9582a22.

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Apply changes from code review

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Add explanation on why cleanup isn't needed

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Change assert on successful pipeline to check logs

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Update description of integration test under pipeline slicing

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Missing formatting

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Update tests directory structure

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

---------

Signed-off-by: Anthony De Bortoli <anthony.debortoli@protonmail.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ivan Danov <idanov@users.noreply.github.com>
Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: Ondrej Zacha <ondrej.zacha@okra.ai>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Yolan Honoré-Rougé <yolan.honore.rouge@gmail.com>
Signed-off-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Signed-off-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com>
Signed-off-by: lrcouto <laurarccouto@gmail.com>
Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com>
Signed-off-by: Puneet Saini <99470400+puneeter@users.noreply.github.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Marcin Zabłocki <m.zablo@gmail.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Ahdra Merali <90615669+AhdraMeraliQB@users.noreply.github.com>
Co-authored-by: Anthony De Bortoli <anthony.debortoli@protonmail.com>
Co-authored-by: Ivan Danov <idanov@users.noreply.github.com>
Co-authored-by: Dmitry Sorokin <40151847+DimedS@users.noreply.github.com>
Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Co-authored-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
Co-authored-by: Ondrej Zacha <ondrej.zacha@okra.ai>
Co-authored-by: ElenaKhaustova <157851531+ElenaKhaustova@users.noreply.github.com>
Co-authored-by: Yolan Honoré-Rougé <29451317+Galileo-Galilei@users.noreply.github.com>
Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
Co-authored-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com>
Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Co-authored-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com>
Co-authored-by: Puneet Saini <99470400+puneeter@users.noreply.github.com>
Co-authored-by: Marcin Zabłocki <m.zablo@gmail.com>
Co-authored-by: Elena Khaustova <ymax70rus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update kedro pipeline create to match starters template for tests
5 participants