Styling and nav fixes on index page #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksolo
suggested changes
Dec 8, 2016
| @@ -0,0 +1,9 @@ | |||
| <% if user_signed_in? %> | |||
| <% @user.games << @game %> | |||
There was a problem hiding this comment.
@JackShelley
This is adding the @GAMe to the users collection. This should take place in the controller, not in a view.
If this action is to add a game to a users collection, then we should come up with a different routing mechanism for that.
| @@ -5,7 +5,7 @@ | |||
| root 'games#index' | |||
| resources :games | |||
| resources :comments | |||
|
|
|||
| get 'games/:id/own' => 'games#own' | |||
There was a problem hiding this comment.
@JackShelley
By rendering this template you cause a change in the resources, this is violating the GET request's property of being idempotent.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ksolo